Add option to save IMS file in a specified location#100
Merged
ehrenfeu merged 8 commits intoimcf:develfrom Jan 21, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #100 +/- ##
====================================
Coverage 25% 25%
====================================
Files 25 25
Lines 1772 1766 -6
====================================
Hits 435 435
+ Misses 1337 1331 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ehrenfeu
requested changes
Jan 19, 2026
- Changed the order of parameters in the run_imarisconvert function to improve compatibility. - Updated docstring to reflect the new parameter order.
ehrenfeu
requested changes
Jan 19, 2026
* Updated the default output folder in run_imarisconvert function to the directory of the input file if not specified. * This change ensures that converted files are saved in a more intuitive location.
ehrenfeu
requested changes
Jan 19, 2026
- Add notes on output folder behavior in docstring. - Specify that if no output folder is provided, the IMS file will be saved in the input file's directory. - Clarify output filename construction from input filename.
- Update docstring to specify that if no output folder is provided, the IMS file will be saved in the same directory as the input file.
ehrenfeu
approved these changes
Jan 21, 2026
ehrenfeu
added
new-minor
Member
|
Needs to be mentioned in changelog: #126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94